Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30881 )
Change subject: nb/intel/i945: Reduce pcidev_on_root() calls ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/30881/1/src/northbridge/intel/i945/northbrid... File src/northbridge/intel/i945/northbridge.c:
https://review.coreboot.org/#/c/30881/1/src/northbridge/intel/i945/northbrid... PS1, Line 87: if (!(reg16 & 2)) {
AFAICT, this bit is only about legacy VGA cycles... […]
Not sure I understand what you mean here. Memory stolen regardless of this bit being set? Looks like we only reserve UMA resource when bit is not set.
Followup needed? As regression fix I think this can still go in...