Hello Aaron Durbin, David Hendricks, build bot (Jenkins), Anjaneya "Reddy" Chagam,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38546
to look at the new patch set (#11).
Change subject: cpu/x86: Make MP init timeout configurable ......................................................................
cpu/x86: Make MP init timeout configurable
The current MP init timeout is hardcoded as 1s. To support platform with many cpus, the timeout needs to be adjusted. The number of cpus is calculated as: number of sockets * number of cores per socket * number of threads per core
How long the timeout should be set to, is heuristic. It needs to be set long enough to ensure reboot stability, but not unreasonable so that real failures can be detected soon enough, especially for smaller systems.
This patch sets timeout to be minimum as 1 second, while each cpu adds 0.1 second.
Signed-off-by: Jonathan Zhang jonzhang@fb.com Signed-off-by: Reddy Chagam anjaneya.chagam@intel.com Change-Id: Ibc079fc6aa8641d4ac8d8e726899b6c8d055052e --- M src/cpu/x86/mp_init.c 1 file changed, 6 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/38546/11