[coreboot-gerrit] Change in coreboot[master]: nb/amd/agesa/family14/northbridge.c: Report missing resources

[Angel Pons (Code Review)]

Attention is currently required from: Nico Huber, Michał Żygowski, Kyösti Mälkki, Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52935 )

Change subject: nb/amd/agesa/family14/northbridge.c: Report missing resources
......................................................................

Patch Set 4:

(1 comment)

File src/northbridge/amd/agesa/family14/northbridge.c:

https://review.coreboot.org/c/coreboot/+/52935/comment/f869fd76_45e124dd 
PS2, Line 382: resource_t
I don't know why the API uses `unsigned long` values nor takes values in KiB (it was like this before I arrived), but I agree it's not ideal.

Nico and I talked about this on IRC a few days ago. We suspect that the choice of KiB was to avoid too much 64-bit code. It should be fine to use `resource_t` as long as code size doesn't increase too much (slot_1 boards have small flash chips).
> Additionally CB:52922 is merged which uses resource_t.

I didn't get to review this change yet. Nico did a post-merge review and left several comments, which I agree with.