[coreboot-gerrit] Change in coreboot[master]: mainboard: Fix comment about early GPIOs

18 Dec 2021

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60210 )
Change subject: mainboard: Fix comment about early GPIOs
......................................................................
mainboard: Fix comment about early GPIOs
These boards program the early GPIO table in bootblock, not romstage.
Change-Id: Iae9353d106483f30cefa2d035d96e63e4c127261
Signed-off-by: Angel Pons th3fanbus@gmail.com
---
M src/mainboard/asrock/h110m/include/gpio.h
M src/mainboard/google/glados/variants/asuka/include/variant/gpio.h
M src/mainboard/google/glados/variants/caroline/include/variant/gpio.h
M src/mainboard/google/glados/variants/cave/include/variant/gpio.h
M src/mainboard/google/glados/variants/chell/include/variant/gpio.h
M src/mainboard/google/glados/variants/glados/include/variant/gpio.h
M src/mainboard/google/glados/variants/lars/include/variant/gpio.h
M src/mainboard/google/glados/variants/sentry/include/variant/gpio.h
M src/mainboard/intel/kblrvp/variants/rvp11/include/variant/gpio.h
M src/mainboard/intel/kblrvp/variants/rvp3/include/variant/gpio.h
M src/mainboard/intel/kblrvp/variants/rvp7/include/variant/gpio.h
M src/mainboard/intel/kblrvp/variants/rvp8/include/variant/gpio.h
M src/mainboard/intel/kunimitsu/gpio.h
M src/mainboard/intel/saddlebrook/gpio.h
M src/mainboard/starlabs/labtop/variants/tgl/gpio.c
M src/mainboard/system76/lemp9/gpio.h
16 files changed, 16 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/60210/1

diff --git a/src/mainboard/asrock/h110m/include/gpio.h b/src/mainboard/asrock/h110m/include/gpio.h
index 9b2193b..18a1eb8 100644
--- a/src/mainboard/asrock/h110m/include/gpio.h
+++ b/src/mainboard/asrock/h110m/include/gpio.h
@@ -455,7 +455,7 @@
    PAD_CFG_NF(GPP_I10, DN_20K, PLTRST, NF1),
 };
-/* Early pad configuration in romstage */
+/* Early pad configuration in bootblock */
 static const struct pad_config early_gpio_table[] = {
    /* ------- GPIO Group GPP_A ------- */
    /* GPP_A0 - RCIN# */
diff --git a/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h b/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h
index d21d9e7..3ee5532 100644
--- a/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h
+++ b/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h
@@ -214,7 +214,7 @@
 /* LANPHYC */		PAD_NC(GPD11, NONE),
 };
-/* Early pad configuration in romstage. */
+/* Early pad configuration in bootblock. */
 static const struct pad_config early_gpio_table[] = {
 /* SPI_WP_STATUS */	PAD_CFG_GPI_GPIO_DRIVER(GPP_C23, UP_20K, DEEP),
 /* GD_UART2_RXD */	PAD_CFG_NF(GPP_C20, NONE, DEEP, NF1),
diff --git a/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h b/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h
index 95d2d04..7f8787c 100644
--- a/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h
+++ b/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h
@@ -231,7 +231,7 @@
 /* LANPHYC */		PAD_NC(GPD11, NONE),
 };
-/* Early pad configuration in romstage. */
+/* Early pad configuration in bootblock. */
 static const struct pad_config early_gpio_table[] = {
 /* UART2_CTS# */	PAD_CFG_GPI_GPIO_DRIVER(GPP_C23, UP_20K, DEEP), /* PCH_WP */
 /* GD_UART2_RXD */	PAD_CFG_NF(GPP_C20, NONE, DEEP, NF1),
diff --git a/src/mainboard/google/glados/variants/cave/include/variant/gpio.h b/src/mainboard/google/glados/variants/cave/include/variant/gpio.h
index cd71eba..0eb7de7 100644
--- a/src/mainboard/google/glados/variants/cave/include/variant/gpio.h
+++ b/src/mainboard/google/glados/variants/cave/include/variant/gpio.h
@@ -223,7 +223,7 @@
 /* LANPHYC */		PAD_NC(GPD11, NONE),
 };
-/* Early pad configuration in romstage. */
+/* Early pad configuration in bootblock. */
 static const struct pad_config early_gpio_table[] = {
 /* UART2_CTS# */	PAD_CFG_GPI_GPIO_DRIVER(GPP_C23, UP_20K, DEEP), /* PCH_WP */
 /* GD_UART2_RXD */	PAD_CFG_NF(GPP_C20, NONE, DEEP, NF1),
diff --git a/src/mainboard/google/glados/variants/chell/include/variant/gpio.h b/src/mainboard/google/glados/variants/chell/include/variant/gpio.h
index ce78ed3..e152862 100644
--- a/src/mainboard/google/glados/variants/chell/include/variant/gpio.h
+++ b/src/mainboard/google/glados/variants/chell/include/variant/gpio.h
@@ -217,7 +217,7 @@
 /* LANPHYC */		PAD_NC(GPD11, NONE),
 };
-/* Early pad configuration in romstage. */
+/* Early pad configuration in bootblock. */
 static const struct pad_config early_gpio_table[] = {
 /* SRCCLKREQ2# */	PAD_CFG_NF(GPP_B7, NONE, DEEP, NF1), /* KEPLER */
 /* UART0_CTS# */	PAD_CFG_GPO(GPP_C11, 0, DEEP), /* EN_PP3300_KEPLER */
diff --git a/src/mainboard/google/glados/variants/glados/include/variant/gpio.h b/src/mainboard/google/glados/variants/glados/include/variant/gpio.h
index fc4eebde..248e7dd 100644
--- a/src/mainboard/google/glados/variants/glados/include/variant/gpio.h
+++ b/src/mainboard/google/glados/variants/glados/include/variant/gpio.h
@@ -220,7 +220,7 @@
 /* LANPHYC */		/* GPD11 */
 };
-/* Early pad configuration in romstage. */
+/* Early pad configuration in bootblock. */
 static const struct pad_config early_gpio_table[] = {
 /* SRCCLKREQ2# */	PAD_CFG_NF(GPP_B7, NONE, DEEP, NF1), /* KEPLER */
 /* UART0_CTS# */	PAD_CFG_GPO(GPP_C11, 0, DEEP), /* EN_PP3300_KEPLER */
diff --git a/src/mainboard/google/glados/variants/lars/include/variant/gpio.h b/src/mainboard/google/glados/variants/lars/include/variant/gpio.h
index 51514b2..ee55512 100644
--- a/src/mainboard/google/glados/variants/lars/include/variant/gpio.h
+++ b/src/mainboard/google/glados/variants/lars/include/variant/gpio.h
@@ -208,7 +208,7 @@
 /* LANPHYC */		PAD_NC(GPD11, NONE),
 };
-/* Early pad configuration in romstage. */
+/* Early pad configuration in bootblock. */
 static const struct pad_config early_gpio_table[] = {
 /* SRCCLKREQ2# */	PAD_CFG_NF(GPP_B7, NONE, DEEP, NF1), /* KEPLER */
 /* UART0_CTS# */	PAD_CFG_GPO(GPP_C11, 0, DEEP), /* EN_PP3300_KEPLER */
diff --git a/src/mainboard/google/glados/variants/sentry/include/variant/gpio.h b/src/mainboard/google/glados/variants/sentry/include/variant/gpio.h
index b4011c7..06f6cd8 100644
--- a/src/mainboard/google/glados/variants/sentry/include/variant/gpio.h
+++ b/src/mainboard/google/glados/variants/sentry/include/variant/gpio.h
@@ -216,7 +216,7 @@
 /* LANPHYC */		PAD_NC(GPD11, NONE),
 };
-/* Early pad configuration in romstage. */
+/* Early pad configuration in bootblock. */
 static const struct pad_config early_gpio_table[] = {
 /* SRCCLKREQ2# */	PAD_CFG_NF(GPP_B7, NONE, DEEP, NF1), /* KEPLER */
 /* SPI_WP_STATUS */	PAD_CFG_GPI_GPIO_DRIVER(GPP_C23, UP_20K, DEEP),
diff --git a/src/mainboard/intel/kblrvp/variants/rvp11/include/variant/gpio.h b/src/mainboard/intel/kblrvp/variants/rvp11/include/variant/gpio.h
index fe8c2e2..aaec3eb 100644
--- a/src/mainboard/intel/kblrvp/variants/rvp11/include/variant/gpio.h
+++ b/src/mainboard/intel/kblrvp/variants/rvp11/include/variant/gpio.h
@@ -257,7 +257,7 @@
 /* LANPHYC */		PAD_CFG_NF(GPD11, NONE, DEEP, NF1),
 };
-/* Early pad configuration in romstage. */
+/* Early pad configuration in bootblock. */
 static const struct pad_config early_gpio_table[] = {
 /* UART0_RXD */		PAD_CFG_NF(GPP_C8, NONE, DEEP, NF1),
 /* UART0_TXD */		PAD_CFG_NF(GPP_C9, NONE, DEEP, NF1),
diff --git a/src/mainboard/intel/kblrvp/variants/rvp3/include/variant/gpio.h b/src/mainboard/intel/kblrvp/variants/rvp3/include/variant/gpio.h
index e0292cf..26eb1d9 100644
--- a/src/mainboard/intel/kblrvp/variants/rvp3/include/variant/gpio.h
+++ b/src/mainboard/intel/kblrvp/variants/rvp3/include/variant/gpio.h
@@ -193,7 +193,7 @@
 /* LANPHYC */		PAD_CFG_NF(GPD11, NONE, DEEP, NF1),
 };
-/* Early pad configuration in romstage. */
+/* Early pad configuration in bootblock. */
 static const struct pad_config early_gpio_table[] = {
 /* UART2_RXD */		PAD_CFG_NF(GPP_C20, NONE, DEEP, NF1),
 /* UART2_TXD */		PAD_CFG_NF(GPP_C21, NONE, DEEP, NF1),
diff --git a/src/mainboard/intel/kblrvp/variants/rvp7/include/variant/gpio.h b/src/mainboard/intel/kblrvp/variants/rvp7/include/variant/gpio.h
index a608505..d2e76d9 100644
--- a/src/mainboard/intel/kblrvp/variants/rvp7/include/variant/gpio.h
+++ b/src/mainboard/intel/kblrvp/variants/rvp7/include/variant/gpio.h
@@ -193,7 +193,7 @@
 /* LANPHYC */		PAD_CFG_NF(GPD11, NONE, DEEP, NF1),
 };
-/* Early pad configuration in romstage. */
+/* Early pad configuration in bootblock. */
 static const struct pad_config early_gpio_table[] = {
 /* UART0_RXD */		PAD_CFG_NF(GPP_C8, NONE, DEEP, NF1),
 /* UART0_TXD */		PAD_CFG_NF(GPP_C9, NONE, DEEP, NF1),
diff --git a/src/mainboard/intel/kblrvp/variants/rvp8/include/variant/gpio.h b/src/mainboard/intel/kblrvp/variants/rvp8/include/variant/gpio.h
index 5b588a1..44997c7 100644
--- a/src/mainboard/intel/kblrvp/variants/rvp8/include/variant/gpio.h
+++ b/src/mainboard/intel/kblrvp/variants/rvp8/include/variant/gpio.h
@@ -159,7 +159,7 @@
};
-/* Early pad configuration in romstage. */
+/* Early pad configuration in bootblock. */
 static const struct pad_config early_gpio_table[] = {
 /* UART0_RXD */		PAD_CFG_NF(GPP_C8, NONE, DEEP, NF1),
 /* UART0_TXD */		PAD_CFG_NF(GPP_C9, NONE, DEEP, NF1),
diff --git a/src/mainboard/intel/kunimitsu/gpio.h b/src/mainboard/intel/kunimitsu/gpio.h
index 439bd89..a436d8f 100644
--- a/src/mainboard/intel/kunimitsu/gpio.h
+++ b/src/mainboard/intel/kunimitsu/gpio.h
@@ -217,7 +217,7 @@
 /* LANPHYC */		PAD_NC(GPD11, NONE),
 };
-/* Early pad configuration in romstage. */
+/* Early pad configuration in bootblock. */
 static const struct pad_config early_gpio_table[] = {
 /* SRCCLKREQ2# */	PAD_CFG_NF(GPP_B7, NONE, DEEP, NF1), /* KEPLER */
 /* SPI_WP_STATUS */	PAD_CFG_GPI_GPIO_DRIVER(GPP_C23, UP_20K, DEEP),
diff --git a/src/mainboard/intel/saddlebrook/gpio.h b/src/mainboard/intel/saddlebrook/gpio.h
index f60515b..b012462 100644
--- a/src/mainboard/intel/saddlebrook/gpio.h
+++ b/src/mainboard/intel/saddlebrook/gpio.h
@@ -245,7 +245,7 @@
 /* LANPHYC */		PAD_CFG_NF(GPD11, NONE, DEEP, NF1),
 };
-/* Early pad configuration in romstage. */
+/* Early pad configuration in bootblock. */
 static const struct pad_config early_gpio_table[] = {
 /* UART0_CTS# */	PAD_CFG_GPO(GPP_C11, 1, DEEP), /* EN_PP3300_KEPLER */
 };
diff --git a/src/mainboard/starlabs/labtop/variants/tgl/gpio.c b/src/mainboard/starlabs/labtop/variants/tgl/gpio.c
index a541c07..81f6cb7 100644
--- a/src/mainboard/starlabs/labtop/variants/tgl/gpio.c
+++ b/src/mainboard/starlabs/labtop/variants/tgl/gpio.c
@@ -7,7 +7,7 @@
  * using the stock BIOS and with coreboot.
  */
-/* Early pad configuration in romstage. */
+/* Early pad configuration in bootblock. */
 const struct pad_config early_gpio_table[] = {
    PAD_CFG_NF(GPP_C20, NONE, DEEP, NF1),
    PAD_CFG_NF(GPP_C21, NONE, DEEP, NF1),
diff --git a/src/mainboard/system76/lemp9/gpio.h b/src/mainboard/system76/lemp9/gpio.h
index 6e9f481..60cc7b6 100644
--- a/src/mainboard/system76/lemp9/gpio.h
+++ b/src/mainboard/system76/lemp9/gpio.h
@@ -10,7 +10,7 @@
/* Name format: <pad name> / <net/pin name in schematics> */
-/* Early pad configuration in romstage. */
+/* Early pad configuration in bootblock. */
 static const struct pad_config early_gpio_table[] = {
    PAD_CFG_NF(GPP_C20, NONE, DEEP, NF1),		/* UART2_RXD */
    PAD_CFG_NF(GPP_C21, NONE, DEEP, NF1),		/* UART2_TXD */
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/60210
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iae9353d106483f30cefa2d035d96e63e4c127261
Gerrit-Change-Number: 60210
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: newchange



    

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

[coreboot-gerrit] Change in coreboot[master]: mainboard: Fix comment about early GPIOs