Attention is currently required from: Martin Roth, Christian Walter, Angel Pons, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52577 )
Change subject: mb/prodrive/hermes: Implement the mainboard option table interface
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/prodrive/hermes/option.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117558):
https://review.coreboot.org/c/coreboot/+/52577/comment/832cb472_aeecbe4c
PS3, Line 9: #define OPTION(x, y) { y, offsetof(struct eeprom_board_settings, x), sizeof(((struct eeprom_board_settings *)NULL)->x), },
line over 96 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52577
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I11fc342c5d422cc3d29392df9c53c7996d6f868e
Gerrit-Change-Number: 52577
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 22 Apr 2021 08:09:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment