Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41757 )
Change subject: drivers/vpd: Fix VPD speed regressions on non-x86 devices
......................................................................
Patch Set 3:
(1 comment)
this looks good to me, but will that work on x86 bootblock/romstage since you've used static?
https://review.coreboot.org/c/coreboot/+/41757/3/src/drivers/vpd/vpd.c
File src/drivers/vpd/vpd.c:
https://review.coreboot.org/c/coreboot/+/41757/3/src/drivers/vpd/vpd.c@157
PS3, Line 157: } else {
do we need this else?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41757
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I55a103180b290c1563e35a25496188b6a82e49ff
Gerrit-Change-Number: 41757
Gerrit-PatchSet: 3
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 27 May 2020 02:47:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment