Attention is currently required from: Christian Walter, Julius Werner, Jett Rink. Jes Klinke has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63158 )
Change subject: tpm: Accept Google Ti50 TPM DID:VID ......................................................................
Patch Set 1:
(1 comment)
File src/drivers/spi/tpm/tpm.c:
https://review.coreboot.org/c/coreboot/+/63158/comment/ae3f23c2_306327af PS1, Line 515: if (tpm_first_access_this_boot()) { : /* This is called for the side-effect of printing the firmware version : string */ : cr50_get_firmware_version(&ver); : }
I think renaming to gsc when it applies to both is helpful. […]
tpm_first_access_this_boot() is a function which returns true in the first stage where this code runs, and false in every subsequent stage. We want to call it in both cases in order to only print the Cr50/Ti50 version string once during boot. (And also in the Cr50 case such that the interrupt pulse length workaround runs only once, and as early as possible.)
Let me work on renaming cr50_firmware_version.