Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34359 )
Change subject: mainboard: Add Lenovo ThinkPad T440p ......................................................................
Patch Set 7:
(8 comments)
patchset 7: adds the F1-F12 as primary option, and adds TPM support.
https://review.coreboot.org/c/coreboot/+/34359/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34359/3//COMMIT_MSG@27 PS3, Line 27: - Mainboard serial number is invalid
Still don't know how to read these information. […]
No good way to fix because the at24rf08c code is built when VENDOR_LENOVO is selected, not going to fix it now.
https://review.coreboot.org/c/coreboot/+/34359/3/Documentation/mainboard/len... File Documentation/mainboard/lenovo/t440p.md:
https://review.coreboot.org/c/coreboot/+/34359/3/Documentation/mainboard/len... PS3, Line 32: Please see :doc:`../../northbridge/intel/haswell/mrc.bin`.
It was used when Sphinx didn't support ../ in path. That has been fixed and is now safe to use.
Done
https://review.coreboot.org/c/coreboot/+/34359/1/src/mainboard/lenovo/t440p/... File src/mainboard/lenovo/t440p/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/34359/1/src/mainboard/lenovo/t440p/... PS1, Line 71: subsystemid 0x17aa 0x220e
missing smbios_slot_desc
Done
https://review.coreboot.org/c/coreboot/+/34359/1/src/mainboard/lenovo/t440p/... PS1, Line 74: subsystemid 0x17aa 0x220e
missing smbios_slot_desc
Done
https://review.coreboot.org/c/coreboot/+/34359/1/src/mainboard/lenovo/t440p/... PS1, Line 156: f
on, for nvidia GPU
Done
https://review.coreboot.org/c/coreboot/+/34359/1/src/mainboard/lenovo/t440p/... File src/mainboard/lenovo/t440p/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/34359/1/src/mainboard/lenovo/t440p/... PS1, Line 20: const u32 cim_verb_data[] = {
missing verbs
Done
https://review.coreboot.org/c/coreboot/+/34359/1/src/mainboard/lenovo/t440p/... File src/mainboard/lenovo/t440p/smihandler.c:
https://review.coreboot.org/c/coreboot/+/34359/1/src/mainboard/lenovo/t440p/... PS1, Line 31: {
can be removed, already done in h8. […]
Done
https://review.coreboot.org/c/coreboot/+/34359/1/src/mainboard/lenovo/t440p/... PS1, Line 37: int mainboard_io_trap_handler(int smif)
can be removed as it has no purpose
Done