Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32346 ) Change subject: [WIP]mb/fujitsu: add Esprimo E900 ...................................................................... Patch Set 14: (2 comments) https://review.coreboot.org/#/c/32346/14/src/superio/smsc/sch5636/acpi/super... File src/superio/smsc/sch5636/acpi/superio.asl: https://review.coreboot.org/#/c/32346/14/src/superio/smsc/sch5636/acpi/super... PS14, Line 103: SCH5147_SHOW_UARTA This looks wrong https://review.coreboot.org/#/c/32346/14/src/superio/smsc/sch5636/early_seri... File src/superio/smsc/sch5636/early_serial.c: https://review.coreboot.org/#/c/32346/14/src/superio/smsc/sch5636/early_seri... PS14, Line 49: smscsuperio_enable_serial sch5636_enable_serial -- To view, visit https://review.coreboot.org/c/coreboot/+/32346 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9e1cdb7cf047d17b2e47a2df26eabbb1593d3a8b Gerrit-Change-Number: 32346 Gerrit-PatchSet: 14 Gerrit-Owner: Eloy Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Eloy Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sun, 30 Jun 2019 15:40:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment