Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39582 )
Change subject: soc/intel/jasperlake: Publish EMMC and SD card ACPI devices
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39582/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39582/2//COMMIT_MSG@8
PS2, Line 8:
BUG and any TEST info.
Done. Added.
https://review.coreboot.org/c/coreboot/+/39582/2//COMMIT_MSG@9
PS2, Line 9: Signed-off-by: Aamir Bohra aamir.bohra@intel.com
Nit: Move this line below Change-Id line.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39582
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70d47455c48990afe9e79c013c5272d70f4f71e7
Gerrit-Change-Number: 39582
Gerrit-PatchSet: 4
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 07 Apr 2020 17:58:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment