Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34359 )
Change subject: mainboard: Add Lenovo ThinkPad T440p ......................................................................
Patch Set 5:
(2 comments)
Schematics for this
https://review.coreboot.org/c/coreboot/+/34359/5/Documentation/mainboard/len... File Documentation/mainboard/lenovo/t440p_all_flash_chips.jpg:
PS5: NM-A131... Schematics for this board say it has a SMSC MSC1633 EC. Why does this board's Kconfig select the H8S then?
https://review.coreboot.org/c/coreboot/+/34359/5/src/mainboard/lenovo/t440p/... File src/mainboard/lenovo/t440p/romstage.c:
https://review.coreboot.org/c/coreboot/+/34359/5/src/mainboard/lenovo/t440p/... PS5, Line 66: dimm_channel0_disabled google/slippy/variants/wolf has the following values for this:
// 0 = leave channel enabled // 1 = disable dimm 0 on channel // 2 = disable dimm 1 on channel // 3 = disable dimm 0+1 on channel .dimm_channel0_disabled = 2, .dimm_channel1_disabled = 2,