Attention is currently required from: Tristan Corrick, Angel Pons, Arthur Heymans, Alexander Couzens, Patrick Rudolph.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51440 )
Change subject: nb/intel/haswell: Decouple mainboard USB config from MRC
......................................................................
Patch Set 10: Code-Review+2
(1 comment)
File src/northbridge/intel/haswell/raminit.h:
https://review.coreboot.org/c/coreboot/+/51440/comment/8f5e3ae7_ccd02ba3
PS7, Line 37: uint16_t
I took the encoding from a comment in pei_data.h that explains the format MRC expects: […]
I still don't understand "octal format". Not sure if a comment that isn't
unambiguous is helpful. I'll try to find a hint in the register description.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51440
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4bc405213e9b0828d9ced18677335533c7dd381d
Gerrit-Change-Number: 51440
Gerrit-PatchSet: 10
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sun, 21 Mar 2021 14:16:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment
