Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46719 )
Change subject: sb/intel/lynxpoint: Drop unnecessary `UL` suffix
......................................................................
Patch Set 7:
Patch Set 7:
Patch Set 7:
Have you tested, that GCC doesn’t complain with overflow(?) warnings as it is signed by default?
GCC generates the exact same binary as before, without any complaints.
GCC warns about these things with `-Wshift-overflow=2`, and there were initiatives to enable that in the past.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46719
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9ba4097cd82c4ff68315a40e1e955e4ed9a43862
Gerrit-Change-Number: 46719
Gerrit-PatchSet: 7
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 25 Oct 2020 11:53:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment