Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35018 )
Change subject: soc/amd/common/block: Create new SPI code ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35018/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35018/2//COMMIT_MSG@10 PS2, Line 10: controller within the FCH to its fullest. What is currently not supported?
https://review.coreboot.org/c/coreboot/+/35018/2//COMMIT_MSG@11 PS2, Line 11: Please add the datasheet name and revision.
https://review.coreboot.org/c/coreboot/+/35018/2/src/soc/amd/common/block/sp... File src/soc/amd/common/block/spi/Kconfig:
https://review.coreboot.org/c/coreboot/+/35018/2/src/soc/amd/common/block/sp... PS2, Line 5: Select this option to add SPI controller functions to the build. Can you be more specific? Without it generic SPI controller functions would be used, or none at all?