Attention is currently required from: Anil Kumar K, Dinesh Gehlot, Eran Mitrani, Jérémy Compostella, Kapil Porwal, Martin L Roth, Martin Roth, Pratikkumar V Prajapati, Shelley Chen, Subrata Banik, Tarun.
Hello Dinesh Gehlot, Eran Mitrani, Kapil Porwal, Martin L Roth, Martin Roth, Pratikkumar V Prajapati, Shelley Chen, Subrata Banik, Tarun, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/78244?usp=email
to look at the new patch set (#24).
The following approvals got outdated and were removed: Code-Review+1 by Pratikkumar V Prajapati, Verified+1 by build bot (Jenkins)
Change subject: soc/intel/mtl: Display Sign-of-Life message using FSP-M ......................................................................
soc/intel/mtl: Display Sign-of-Life message using FSP-M
Meteor Lake Firmware Support Package (FSP-M) for ChromeOS includes an pre-memory graphics driver which can be leverage to display a text message thanks to the following FSP-M UPD (Updateable Product Data):
- VgaInitControl (bitfield):
Bit 0: Turn on graphics, setup VGA text mode and display `VgaMessage' text centered on the screen.
Bit 1: Clear text and tear down VGA text mode and graphics before returning from FSP-M.
- VbtPtr (address): Pointer to the VBT (Video BIOS Tables) binary.
- VbtSize (unsigned int): Size of the VBT binary.
- LidStatus (boolean): Due to limited resources at early boot stages, the text message is displayed on a single monitor. The lid status helps decide which display is the most appropriate.
0: Lid is closed: show the text message on the external display if avaiable, do not display anything otherwise.
1: Lid is open: show the message on the internal display if available, use an external display if available otherwise.
- VgaMessage (string): Text message to display.
If the `SOC_INTEL_METEORLAKE_SIGN_OF_LIFE' flag is set, coreboot configures the UPDs above to display a text message during memory training and CSME update. The text message can be configured via the locale text mechanism using the `memory_training_desc' name.
The `SOC_INTEL_METEORLAKE_SIGN_OF_LIFE' selects the LZ4 compression algorithm for VBT because LZMA decompression is not available in romstage by default and adding LZMA support increases the romstage binary size more than the VBT binary is reduced.
BUG=b:279173035 TEST=Text message is displayed during memory training on a rex board
Change-Id: I8e7772582b1895fa8e38780932346683be998558 Signed-off-by: Jeremy Compostella jeremy.compostella@intel.com --- M src/soc/intel/meteorlake/Kconfig M src/soc/intel/meteorlake/romstage/fsp_params.c 2 files changed, 64 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/78244/24