ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31059 )
Change subject: src/mb/sifive/hifive-unleashed: initialize Gigabit Ethernet Controller ......................................................................
Patch Set 9:
(2 comments)
unless this ethernet is causing a problem I don't see the reason to do it in the romstage.
https://review.coreboot.org/#/c/31059/9/src/mainboard/sifive/hifive-unleashe... File src/mainboard/sifive/hifive-unleashed/romstage.c:
https://review.coreboot.org/#/c/31059/9/src/mainboard/sifive/hifive-unleashe... PS9, Line 59: while (*(volatile long *)&nsec > 0) setp -> step I think?
https://review.coreboot.org/#/c/31059/9/src/mainboard/sifive/hifive-unleashe... PS9, Line 99: phy_init(); normally this sort of thing goes in the ramstage; is there a need to do it here?