build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37738 )
Change subject: southbridge/amd: deduplicate MMIO macro [WIP] ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37738/1/src/southbridge/amd/common/... File src/southbridge/amd/common/amd_defs.h:
https://review.coreboot.org/c/coreboot/+/37738/1/src/southbridge/amd/common/... PS1, Line 22: #define SB_MMIO_MISC32(x) *(volatile u32 *)(AMD_SB_ACPI_MMIO_ADDR + 0xE00 + (x)) Macros with complex values should be enclosed in parentheses