Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47584 )
Change subject: soc/amd: factor out vbnv_cmos_failed() into common block ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47584/2/src/soc/amd/common/block/vb... File src/soc/amd/common/block/vbnv_cmos/Kconfig:
https://review.coreboot.org/c/coreboot/+/47584/2/src/soc/amd/common/block/vb... PS2, Line 1: SOC_AMD_COMMON_BLOCK_VBNV_CMOS
I think of common "block" as representing an IP block in the platform. […]
oh, I interpreted the block part as firmware building blocks which 90% of the time is more or less the same, but not in this case. putting the functionality under soc/amd/common/vboot and not having an extra Kconfig symbol for this sounds good to me; all AMD SoCs need that when selecting CONFIG_VBOOT_VBNV_CMOS anyway. will push an updated version later today