[coreboot-gerrit] [L] Change in coreboot[main]: mb/amd/crater: Add Crater mainboard support for Renoir/Cezanne SOC

[Felix Held (Code Review)]

Attention is currently required from: Ana Carolina Cabral, Anand Vaikar, Bao Zheng, Fred Reitberger, Jason Glenesk, Matt DeVillier.

Felix Held has posted comments on this change by Anand Vaikar. ( https://review.coreboot.org/c/coreboot/+/85749?usp=email )

Change subject: mb/amd/crater: Add Crater mainboard support for Renoir/Cezanne SOC
......................................................................

Patch Set 9:

(4 comments)

Patchset:

PS9: 
one small change request; the rest looks good to me. the other comments are more todos for future patches

File src/mainboard/amd/crater/Kconfig:

https://review.coreboot.org/c/coreboot/+/85749/comment/5a8b177d_bb5169f1?usp... :
PS9, Line 28: && BOARD_AMD_CRATER_RENOIR
this condition is redundant, sonce it's already in an if BOARD_AMD_CRATER_RENOIR block. missed that one in the last review round

File src/mainboard/amd/crater/port_descriptors_renoir.c:

https://review.coreboot.org/c/coreboot/+/85749/comment/b6b0194e_2d25174d?usp... :
PS9, Line 46: ASPM_DISABLED
disabling ASPM for the SSD seems unexpected to me, but that power optimization can be looked into later. let's land the board first and then do some of the smaller optimizations

https://review.coreboot.org/c/coreboot/+/85749/comment/d4bbc7f6_5c56bde7?usp... :
PS9, Line 54: };
without having checked the schematic, it looks to me that we're missing some dxio descriptors here. i'm ok with addressing that one in some a follow-up patch in the future