Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33824 )
Change subject: mainboard/google/hatch: create akemi variant.
......................................................................
Patch Set 10:
(4 comments)
https://review.coreboot.org/c/coreboot/+/33824/10//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/33824/10//COMMIT_MSG@11
PS10, Line 11: BUG=none
Please file an issue in Google issue tracker to track the status of creating new Akemi firmware including EC and BIOS.
https://review.coreboot.org/c/coreboot/+/33824/10//COMMIT_MSG@14
PS10, Line 14: /build/hatch/firmware/coreboot-private/3rdparty/blobs/baseboard/hatch
It seems to me that the path here is for these private blobs like VBT, fitimage or SAR?
https://review.coreboot.org/c/coreboot/+/33824/10/src/mainboard/google/hatch...
File src/mainboard/google/hatch/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/33824/10/src/mainboard/google/hatch...
PS10, Line 3:
redundant line
https://review.coreboot.org/c/coreboot/+/33824/10/src/mainboard/google/hatch...
File src/mainboard/google/hatch/variants/akemi/include/variant/ec.h:
https://review.coreboot.org/c/coreboot/+/33824/10/src/mainboard/google/hatch...
PS10, Line 4: 2018
2019
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33824
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1a868839e2c598f8052d37c99713bc58b21e887c
Gerrit-Change-Number: 33824
Gerrit-PatchSet: 10
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Marx Wang
marx.wang@intel.corp-partner.google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Paul Ma
magf@bitland.corp-partner.google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Xingyu Wu
wuxy@bitland.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 02 Aug 2019 10:15:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment