[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: log the memory part name

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45459 )

Change subject: soc/intel/tigerlake: log the memory part name
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45459/5/src/lib/spd_bin.c 
File src/lib/spd_bin.c:

https://review.coreboot.org/c/coreboot/+/45459/5/src/lib/spd_bin.c@148 
PS5, Line 148: 	if (spd_part_name_override && strlen(spd_part_name_override)) {
Since in this case, you don't know what type of `spd` it is you're dealing with, how do you know how many bytes should be copied into `spd_name`? If it's DDR3, then it should be DDR3_SPD_PART_LEN, if it's DDR4, then it should be DDR4_SPD_PART_LEN... I think this may need to go into the different case statements below because of that. At minimum, a length check is needed when doing a memcpy() w/ a strlen()