Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39189 )
Change subject: sb/lynxpoint: hook up smmstore
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/39189/1/src/southbridge/intel/lynxp...
File src/southbridge/intel/lynxpoint/smihandler.c:
https://review.coreboot.org/c/coreboot/+/39189/1/src/southbridge/intel/lynxp...
PS1, Line 286: io_smi->rax = ret;
code indent should use tabs where possible
Hmmmmm...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39189
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I64f520d17146206b8b9b41fc4f827539c5cfd507
Gerrit-Change-Number: 39189
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 01 Mar 2020 21:05:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment