Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39812 )
Change subject: mb/google/dedede: Read DRAM population strap ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39812/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39812/3//COMMIT_MSG@9 PS3, Line 9: Configure DRAM population strap GPIO. Read the strap and pass that … according to the schematics.
https://review.coreboot.org/c/coreboot/+/39812/3/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/include/baseboard/gpio.h:
https://review.coreboot.org/c/coreboot/+/39812/3/src/mainboard/google/dedede... PS3, Line 29: /* Memory channel select strap - 0:fully-populated, 1:half-populated */ Add one space after each colon?