Raymond Chung has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38826 )
Change subject: mb/google/hatch: Create nightfury variant ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/38826/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38826/1//COMMIT_MSG@2 PS1, Line 2: raymondchung
Please use *Raymond Chung*.
ok
https://review.coreboot.org/c/coreboot/+/38826/1//COMMIT_MSG@7 PS1, Line 7: /mb/google/hatch: Create nightfury variant
Please remove the leading /.
ok
https://review.coreboot.org/c/coreboot/+/38826/1//COMMIT_MSG@9 PS1, Line 9: Create new variant for nightfury
How did you create the variant?
According to the needs of issue 149226871. We refer to CLs of jinlon to create new variant.
https://review.coreboot.org/c/coreboot/+/38826/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/nightfury/ramstage.c:
https://review.coreboot.org/c/coreboot/+/38826/1/src/mainboard/google/hatch/... PS1, Line 27: Kohaku
Is that name correct?
Sorry! It is not correct. The correct name is nightfury.