Jan Samek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74433?usp=email )
Change subject: drivers/i2c: Add PI7C9X2G608GP PCIe switch driver (pi608gp)
......................................................................
Patch Set 17:
(1 comment)
File src/drivers/i2c/pi608gp/pi608gp.c:
https://review.coreboot.org/c/coreboot/+/74433/comment/6bbb19d7_29746bb5 :
PS17, Line 59: if (allowed[i].lvl == level_mv.lvl && allowed[i].lvl_10 == level_mv.lvl_10)
Doesn't look like it (to me it would look like C++ behavior): […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74433?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id191c4e97b99da58efd3ba38bf8cca3603ece4d5
Gerrit-Change-Number: 74433
Gerrit-PatchSet: 17
Gerrit-Owner: Jan Samek
jan.samek@siemens.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 09 Jun 2023 13:33:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Jan Samek
jan.samek@siemens.com
Gerrit-MessageType: comment