[coreboot-gerrit] Change in coreboot[master]: cpu/intel/model_206ax: Replace `generate_cstate_entries`

[Angel Pons (Code Review)]

Attention is currently required from: Nico Huber, Arthur Heymans, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49093 )

Change subject: cpu/intel/model_206ax: Replace `generate_cstate_entries`
......................................................................

Patch Set 2:

(2 comments)

File src/cpu/intel/model_206ax/acpi.c:

https://review.coreboot.org/c/coreboot/+/49093/comment/f234d213_1d3dfe3c 
PS2, Line 54: acpi_cstates
> possible buffer overflow.

Sorry, I don't follow. Do you mean a buffer overflow can happen if a devicetree contains invalid `acpi_cX` values?

https://review.coreboot.org/c/coreboot/+/49093/comment/eda43efe_b54b4186 
PS2, Line 55: i + 1
> shouldn't the ctype be already correct here? why do you need to update it?

I'm just doing what the original code did.