Attention is currently required from: Furquan Shaikh, Felix Held.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48842 )
Change subject: soc/amd/: Add an option to select if SOC supports ESPI sub decode
......................................................................
Patch Set 28:
(2 comments)
File src/soc/amd/common/block/lpc/espi_util.c:
https://review.coreboot.org/c/coreboot/+/48842/comment/5d6b7a13_d10d613d
PS1, Line 828: SOC_AMD_CEZANNE
might also be worth a thought to move the check to espi_setup and only call espi_setup_subtractive_d […]
Done
https://review.coreboot.org/c/coreboot/+/48842/comment/50e3da75_00c119bb
PS1, Line 828: SOC_AMD_CEZANNE
might also be worth a thought to move the check to espi_setup and only call espi_setup_subtractive_d […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48842
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icb8e8a1a59393849395125108bfaa884839ce10f
Gerrit-Change-Number: 48842
Gerrit-PatchSet: 28
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 25 Jan 2021 10:38:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment