Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30942 )
Change subject: mainboard/samsung/350v5c: add initial board files ......................................................................
Patch Set 2:
(3 comments)
Patch Set 2:
Here are the errors that are causing the build to fail verification:
src/mainboard/samsung/350v5c/acpi/ec.asl has no recognized license header. src/mainboard/samsung/350v5c/acpi/platform.asl has no recognized license header. src/mainboard/samsung/350v5c/dsdt.asl has no recognized license header. src/mainboard/samsung/350v5c/mainboard.c has no recognized license header. Error: Undefined Symbol 'BOARD_ROMSIZE_KB_6144' used at src/mainboard/samsung/350v5c/Kconfig:5
The license header errors are trivial to address. The latter should be addressed in a separate patch.
https://review.coreboot.org/#/c/30942/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/30942/2//COMMIT_MSG@7 PS2, Line 7: update board_info.txt with correct info add new mainboard
https://review.coreboot.org/#/c/30942/2/src/mainboard/samsung/350v5c/board_i... File src/mainboard/samsung/350v5c/board_info.txt:
https://review.coreboot.org/#/c/30942/2/src/mainboard/samsung/350v5c/board_i... PS2, Line 4: SOP Usually referred to as SOIC, even if it's less precise.
https://review.coreboot.org/#/c/30942/2/src/mainboard/samsung/350v5c/board_i... PS2, Line 6: no n