Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32617 )
Change subject: mb/lenovo/*: Add support for VBOOT on 12MiB devices ......................................................................
Patch Set 5:
(10 comments)
https://review.coreboot.org/c/coreboot/+/32617/4/src/mainboard/lenovo/t530/v... File src/mainboard/lenovo/t530/vboot-rwab.fmd:
https://review.coreboot.org/c/coreboot/+/32617/4/src/mainboard/lenovo/t530/v... PS4, Line 8: 0x00000
no need to define the base.
Done
https://review.coreboot.org/c/coreboot/+/32617/4/src/mainboard/lenovo/t530/v... PS4, Line 9: @0x0
only define size
Done
https://review.coreboot.org/c/coreboot/+/32617/4/src/mainboard/lenovo/t530/v... PS4, Line 10: @0x10000 0x16ffc0
don't define anything such that it fills up RW_SECTION_A
Done
https://review.coreboot.org/c/coreboot/+/32617/4/src/mainboard/lenovo/t530/v... PS4, Line 11: @0x17ffc0
Don't define the base.
Done
https://review.coreboot.org/c/coreboot/+/32617/4/src/mainboard/lenovo/t530/v... PS4, Line 13: RW_SECTION_B@0x280000 0x280000 { : VBLOCK_B@0x0 0x10000 : FW_MAIN_B(CBFS)@0x10000 0x16ffc0 : RW_FWID_B@0x17ffc0 0x40 : }
see RW_SECTION_B
Done
https://review.coreboot.org/c/coreboot/+/32617/4/src/mainboard/lenovo/t530/v... PS4, Line 22: @0x520000
don't define the base
Done
https://review.coreboot.org/c/coreboot/+/32617/4/src/mainboard/lenovo/t530/v... PS4, Line 25: 0x581000 0x17f000
don't define this at all to make sure it fills up all the space.
Done
https://review.coreboot.org/c/coreboot/+/32617/4/src/mainboard/lenovo/t530/v... PS4, Line 26: FMAP@0x0 0x800 : RO_FRID@0x800 0x40 : RO_PADDING@0x840 0x7c0 : RO_VPD(PRESERVE)@0x1000 0x1000 : GBB@0x2000 0x1e000
only define sizes on these.
Done
https://review.coreboot.org/c/coreboot/+/32617/4/src/mainboard/lenovo/t530/v... PS4, Line 31: @0x20000 0x15f000
Don't define base/size such that it it will take in all available space.
Done
https://review.coreboot.org/c/coreboot/+/32617/3/src/mainboard/lenovo/x230/b... File src/mainboard/lenovo/x230/board.fmd:
https://review.coreboot.org/c/coreboot/+/32617/3/src/mainboard/lenovo/x230/b... PS3, Line 9: SMMSTORE(PRESERVE)@0x10000 0x40000
it allows to use the SMMSTORE once https://review.coreboot. […]
Done