Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31194 )
Change subject: intel/apollolake: Add parameter to enable VTD in devicetree ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31194/1/src/soc/intel/apollolake/chip.h File src/soc/intel/apollolake/chip.h:
https://review.coreboot.org/#/c/31194/1/src/soc/intel/apollolake/chip.h@192 PS1, Line 192: VTD
Please add a quick explanation, what VTD is in the comment.
Will add the description in the commit message.
https://review.coreboot.org/#/c/31194/1/src/soc/intel/apollolake/chip.h@196 PS1, Line 196: uint8_t enable_vtd;
Newer platforms have a vtd_disable. […]
Where have you seen it in the tree? The only thing I can find like "vtd_disable" is this one bit in the CAPID_A register. This has a slightly different meaning as it dos not target a FSP parameter. If I switch the logic to "vtd_disable", then we will have a conflict with the default (so to speak not set) devicetree value resulting in the need of setting it on all APL+GLK based mainboards. Or did I get you wrong?