Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35601 )
Change subject: arch/x86: Fix __ROMCC__ automatic prerequisities ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/35601/1/src/arch/x86/Makefile.inc File src/arch/x86/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35601/1/src/arch/x86/Makefile.inc@1... PS1, Line 164: $(CC_bootblock) -D__ROMCC__ -D__PRE_RAM__ -D__BOOTBLOCK__ $(CPPFLAGS_bootblock) -MM -MT$(objgenerated)/bootblock.inc \
I expected -D__PRE_RAM__ -D__BOOTBLOCK__ to appear in CPPFLAGS_xx but they do not?
They're explicitly added to command lines in the create_cc_template macro (Makefile:351, look for $(3)). Might want to revisit this, but that part of the build system is arcane enough as-is ;-)