Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31486 )
Change subject: soc/amd/common: Refactor AmdCreateStruct() use ......................................................................
Patch Set 5: Code-Review+2
(2 comments)
https://review.coreboot.org/#/c/31486/5/src/soc/amd/common/block/pi/agesawra... File src/soc/amd/common/block/pi/agesawrapper.c:
https://review.coreboot.org/#/c/31486/5/src/soc/amd/common/block/pi/agesawra... PS5, Line 68: aip
Consistent with src/drivers/amd/agesa/state_machine. […]
Unfortunately that's not true. AGESA varies depending on Carrizo/Bristol, FP4/FT4, and the associated southbridge. There's one AGESA for stoneyridge, another for Merlin falcon, and so on. But I'll accept your reasons.
https://review.coreboot.org/#/c/31486/5/src/soc/amd/common/block/pi/agesawra... PS5, Line 111: return module_dispatch(AMD_RELEASE_STRUCT, &aip->StdHeader);
Can you elaborate what change you see and where in source code, where did this replace originate hap […]
The return of is internal to AGESA. That said, look agesa.c line 58 to see where it's replaced by unsupported. The die actually happens in line 102 above (it does not happens in amd_init_reset because at init reset the physical pointer is created ByHost. I have seen this myself in a project with SOC merlinfalcon, where the returned status was a bounds check and it died at amd_init_early. So I know there will be no ill effect simply because it'll die on a situation where it could cause such problem.