Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37106 )
Change subject: mb/google/hatch/variant/kohaku: Config MEM_STRAP GPIOs
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37106/2/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/kohaku/gpio.c:
https://review.coreboot.org/c/coreboot/+/37106/2/src/mainboard/google/hatch/...
PS2, Line 94: Note: the Hatch platform's romstage will configure
: * the MEM_STRAP_* (a.k.a GPIO_MEM_CONFIG_*) pins
: * as inputs before it reads them, so they are not
: * needed in this table.
This comment conflicts directly with the change below. :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37106
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8f7105b3925f17c1741660d84c83c5d15f398a8d
Gerrit-Change-Number: 37106
Gerrit-PatchSet: 2
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 28 Nov 2019 21:46:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment