Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35110 )
Change subject: mb/google/kukui: Load calibration params and run DRAM calibration flow ......................................................................
Patch Set 47:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35110/47/src/mainboard/google/kukui... File src/mainboard/google/kukui/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35110/47/src/mainboard/google/kukui... PS47, Line 35: DRAM_CBFS := $(CONFIG_CBFS_PREFIX)/dram
@hungte Should we move the changes in this file to soc/mediatek/mt8183/Makefile. […]
That may be a good idea. In the meantime I think we should make it a Kconfig. Would be best if in the end we can override it from configs so chrome os local builds can use files from local repo. Maybe config
MT8183_DRAM_FULLK_BLOB default "3rdparty/blobs/soc/mediatek/mt8183/dram.elf"
https://review.coreboot.org/c/coreboot/+/35110/47/src/mainboard/google/kukui... File src/mainboard/google/kukui/romstage.c:
https://review.coreboot.org/c/coreboot/+/35110/47/src/mainboard/google/kukui... PS47, Line 36: BIOS_INFO BIOS_DEBUG
https://review.coreboot.org/c/coreboot/+/35110/47/src/mainboard/google/kukui... PS47, Line 44: assert(length <= CALIBRATION_REGION_SIZE); Can we replace this with Static_assert?
https://review.coreboot.org/c/coreboot/+/35110/47/src/mainboard/google/kukui... PS47, Line 55: .write_to_flash = &write_calibration_data_to_flash,
@hungte Should we also put get_sdram_config() into dramc_param_ops?
sounds like a good idea.
we may even put the CONFIG_EMCP thing into a function like
.get_config