Attention is currently required from: Julius Werner, Angel Pons, Subrata Banik, Aaron Durbin.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51445 )
Change subject: timestamp: Add helper fucntions
......................................................................
Patch Set 3:
(1 comment)
File src/include/timestamp.h:
https://review.coreboot.org/c/coreboot/+/51445/comment/15bdd1fd_af8bd35f
PS3, Line 26: * Add a new raw timestamp in microseconds into timestamp_table at index 'n'.
This might be going a bit far, but what do we actually gain by keeping the timestamp table in TSC fr […]
IIUC, the reason why x86 platforms store in TSC frequency is because the timestamp values are basically the raw values read by using `rdtsc` instruction. Thus, in the normal case, there is no need for conversion. If the values are to be stored in usecs, then for each timestamp_get() call, rdtsc value will have to be converted using TSC frequency.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51445
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6b7065ed26e231fc898ae44bcc15cba6fb42b308
Gerrit-Change-Number: 51445
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Sun, 04 Apr 2021 04:01:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment