Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/29832 )
Change subject: x86/acpi: Add Kconfig to toggle 8259 reporting ......................................................................
x86/acpi: Add Kconfig to toggle 8259 reporting
Change-Id: If3c9783ebc41c103c915788139d91644b805f397 Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/29832 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M src/arch/x86/Kconfig M src/arch/x86/acpi.c 2 files changed, 10 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved
diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig index 242a7cf..827c1cb 100644 --- a/src/arch/x86/Kconfig +++ b/src/arch/x86/Kconfig @@ -265,6 +265,14 @@ Note that it is the responsibility of the payload to reset the normal boot bit to 1 after each successful boot.
+config ACPI_NO_PCAT_8259 + bool + help + Selected by platforms that don't expose a PC/AT 8259 PIC pair. + +config ACPI_HAVE_PCAT_8259 + def_bool y if !ACPI_NO_PCAT_8259 + config ACPI_CPU_STRING string default "\_PR.CP%02d" diff --git a/src/arch/x86/acpi.c b/src/arch/x86/acpi.c index f08a401..8a620bb 100644 --- a/src/arch/x86/acpi.c +++ b/src/arch/x86/acpi.c @@ -229,7 +229,8 @@ header->revision = get_acpi_table_revision(MADT);
madt->lapic_addr = LOCAL_APIC_ADDR; - madt->flags = 0x1; /* PCAT_COMPAT */ + if (CONFIG(ACPI_HAVE_PCAT_8259)) + madt->flags |= 1;
current = acpi_fill_madt(current);