Po Xu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46390 )
Change subject: soc/mediatek: Move auxadc driver from MT8183 to common ......................................................................
Patch Set 30:
(5 comments)
https://review.coreboot.org/c/coreboot/+/46390/29//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46390/29//COMMIT_MSG@13 PS29, Line 13: Mediatek
MediaTek
Done
https://review.coreboot.org/c/coreboot/+/46390/29//COMMIT_MSG@13 PS29, Line 13: SOCs
SoCs
Done
https://review.coreboot.org/c/coreboot/+/46390/29/src/soc/mediatek/mt8183/Ma... File src/soc/mediatek/mt8183/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/46390/29/src/soc/mediatek/mt8183/Ma... PS29, Line 3: bootblock-y += ../common/auxadc.c
Move it right after bootblock. […]
Done
https://review.coreboot.org/c/coreboot/+/46390/29/src/soc/mediatek/mt8183/Ma... PS29, Line 47: ramstage-y += ../common/auxadc.c
Move it after emi. […]
Done
https://review.coreboot.org/c/coreboot/+/46390/29/src/soc/mediatek/mt8183/in... File src/soc/mediatek/mt8183/include/soc/auxadc.h:
https://review.coreboot.org/c/coreboot/+/46390/29/src/soc/mediatek/mt8183/in... PS29, Line 21: mt8183_infracfg_regs
Is this the same as mt8192_infracfg_regs? If so, we can further merge them.
yes, Since mt8192 has mt8192_infracfg_regs, So it needs to be written separately, and then I define a common variable to make the .c file common.