Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/27561 )
Change subject: drivers/i2c/da7219: Add vddio property
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/27561/1/src/drivers/i2c/da7219/chip.h
File src/drivers/i2c/da7219/chip.h:
https://review.coreboot.org/#/c/27561/1/src/drivers/i2c/da7219/chip.h@33
PS1, Line 33: unsigned vddio;
Prefer 'unsigned int' to bare use of 'unsigned'
Thank you for the advice Jenkins, but I was keeping consistent with the rest of this file here.
--
To view, visit
https://review.coreboot.org/27561
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87ff6e22e2d38e984a8fd7f8434e3f55fd3def24
Gerrit-Change-Number: 27561
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Kurtz
djkurtz@google.com
Gerrit-Reviewer: Akshu Agrawal
akshu.agrawal@amd.com
Gerrit-Reviewer: Daniel Kurtz
djkurtz@chromium.org
Gerrit-Reviewer: Daniel Kurtz
djkurtz@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 21 Jul 2018 00:26:17 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No