Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39145 )
Change subject: arch/x86/acpigen: Add new helper routines for XOR and get_rx_gpio
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39145/2/src/arch/x86/acpigen.c
File src/arch/x86/acpigen.c:
https://review.coreboot.org/c/coreboot/+/39145/2/src/arch/x86/acpigen.c@1776
PS2, Line 1776: acpigen_write_xor
Now that I have it, I think it may help some one else in future hopefully :-)
Oops yeah, I believe our write_not() is bitwise Not, instead of LNot (logical not).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39145
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d65699d3c806007a50adcb51c5d84567ce451b7
Gerrit-Change-Number: 39145
Gerrit-PatchSet: 3
Gerrit-Owner: Rajat Jain
rajatja@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Rajat Jain
rajatja@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Thu, 27 Feb 2020 19:15:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rajat Jain
rajatja@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment