Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44799 )
Change subject: soc/intel/elkhartlake/bootblock: Do initial SoC commit until bootblock ......................................................................
Patch Set 7:
Sorry for late reply, got tied up with other projects only have time recently to resume my upstreaming work again.
No worries. I had noticed that there wasn't more EHL work.
There are many differences on PCH side for EHL & JSL. Just for your understanding, we used to plan to merge in TGL, JSL & EHL into one SOC folder, but google folks found there are too many config params hence they decided to split them out. That's why we have 3 separate platforms now.
Ack, thanks for the clarification. I've also looked into some datasheets, I guess they only share the CPU cores?
Good point, let me upstream the mainboard folder right away, will take note of this in future.
I've worked on something in the meantime: CB:45710. It can serve as a starting point for future SoCs, to bring things up step by step and build-tested from the beginning. It won't work with the already merged EHL base (because it already has too many dependencies drawn in), so really something for the future.
The main reason we are using JSL as our base model also based on our agreed model with Google folks and the community, that we will follow the model used by TGL: https://review.coreboot.org/q/topic:%22TGL_UPSTREAM%22+(status:open%20OR%20s...) This model is being used across all latest Intel platforms (JSL, ADL etc).
It's a controversial model because it skips a lot of review. I guess what Intel client folks and Google do there is trying to minimize time to market at any cost. If one has all the resources, that's not a problem I guess.
Please let me know if you have any concern otherwise, hope these answer your questions.
My only concern is that this might not be the easiest way. But that depends much on the quality goal. I guess it's the way to get something booting fast and then let quality sink in over the years.