Attention is currently required from: Martin Roth, Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49375 )
Change subject: soc/amd/stoneyridge: use SOC_AMD_COMMON_BLOCK_UART
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49375/comment/d1a2a818_e340361e
PS2, Line 10: any more
nit: anymore
https://review.coreboot.org/c/coreboot/+/49375/comment/881a3551_5d8fa319
PS2, Line 12: by
nit: `replace (old) *with* (new)`
I would use `by` in expressions like `(old) was replaced by (new)`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49375
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I09c15566a402895d6388715e8e5a802dc3c94fdd
Gerrit-Change-Number: 49375
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 13 Jan 2021 18:42:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment