18 Nov
2022
18 Nov
'22
7:02 p.m.
Attention is currently required from: Maximilian Brune, Angel Pons, Arthur Heymans, Lean Sheng Tan.
David Milosevic has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68137 )
Change subject: [WIP] mb/prodrive/atlas: Populate smbios table with VPD from ECs EMI ......................................................................
Patch Set 12:
(1 comment)
File src/mainboard/prodrive/atlas/vpd.h:
https://review.coreboot.org/c/coreboot/+/68137/comment/34cfba15_0fea86be PS11, Line 13: __packed
Yep, I can remove that.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/68137
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47bb4883c43ff344a9bda92c3106dd025533b391
Gerrit-Change-Number: 68137
Gerrit-PatchSet: 12
Gerrit-Owner: David Milosevic David.Milosevic@9elements.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: Maximilian Brune maximilian.brune@9elements.com
Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Attention: Maximilian Brune maximilian.brune@9elements.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-Comment-Date: Fri, 18 Nov 2022 17:02:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Comment-In-Reply-To: David Milosevic David.Milosevic@9elements.com
Gerrit-MessageType: comment