Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85860?usp=email )
Change subject: soc/mediatek/common/dp: Move common functions to dptx_common.c ......................................................................
Patch Set 5:
(11 comments)
File src/soc/mediatek/common/dp/dptx.c:
https://review.coreboot.org/c/coreboot/+/85860/comment/f5daafad_e021790b?usp... : PS3, Line 15: dptx_link_train_clock_recovery_delay
Looks the same as mt8196's `drm_dp_link_train_clock_recovery_delay`, except that in the edge case (` […]
Done
https://review.coreboot.org/c/coreboot/+/85860/comment/94e0386f_fe90bd40?usp... : PS3, Line 32: dptx_link_train_channel_eq_delay
Same here.
Done
https://review.coreboot.org/c/coreboot/+/85860/comment/0ca98c2b_b5812c9c?usp... : PS3, Line 49: dptx_channel_eq_ok
Looks the same as mt8196's `drm_dp_channel_eq_ok`.
Done
https://review.coreboot.org/c/coreboot/+/85860/comment/eb990f6b_beee6e3a?usp... : PS3, Line 425: dptx_set_trainingstart
I think it's also possible to share this with mt8196. The differences are: […]
It is difficult for me to realize whole flow within one or two days (plus verification on mt8188/mt8196). Current target is to mitigate the upstream progress of the MT8196 eDP driver. I think there are still a lot of works on DPTX_HAL refactoring. I would like to the keep current approach and refactor this function when I have the spare time.
https://review.coreboot.org/c/coreboot/+/85860/comment/c1dd2bb8_98c3e598?usp... : PS3, Line 536: static void dptx_video_enable(struct mtk_dp *mtk_dp, bool enable)
Looks the same as mt8196.
Done
https://review.coreboot.org/c/coreboot/+/85860/comment/faafadfa_7f81d549?usp... : PS3, Line 559: dptx_video_config
Can this be shared with mt8196?
Done
File src/soc/mediatek/common/dp/include/soc/dptx_common.h:
https://review.coreboot.org/c/coreboot/+/85860/comment/2559e946_5916d5e1?usp... : PS3, Line 50: DP_LANE_CHANNEL_EQ_DONE | \
align
Done
https://review.coreboot.org/c/coreboot/+/85860/comment/0772b7d5_5048d33d?usp... : PS3, Line 107:
tabs
Done
https://review.coreboot.org/c/coreboot/+/85860/comment/f6c64965_75508d5f?usp... : PS3, Line 214: dptx_get_lane_status
If `dptx_channel_eq_ok` is shared with mt8196, then this can be static.
Done
https://review.coreboot.org/c/coreboot/+/85860/comment/7f522990_e580e41c?usp... : PS3, Line 217: bool dptx_auxwrite_bytes(struct mtk_dp *mtk_dp, u8 cmd, u32 dpcd_addr,
`dptx_auxwrite_bytes` and `dptx_auxread_bytes` can be static functions.
Done
https://review.coreboot.org/c/coreboot/+/85860/comment/7321a3df_2e500db1?usp... : PS3, Line 221: void dptx_videomute(struct mtk_dp *mtk_dp, bool enable); : void dptx_set_dptxout(struct mtk_dp *mtk_dp);
These 2 functions can be static if `dptx_video_enable` is shared with mt8196.
Done