Kyösti Mälkki (kyosti.malkki@gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8531
-gerrit
commit 2394e7092e9dfba330524bccfd4d5f4ad6de579a Author: Kyösti Mälkki kyosti.malkki@gmail.com Date: Tue Feb 24 14:44:49 2015 +0200
AGESA fam16: Drop HyperTransport scan
Already done for fam15tn/rl.
Change-Id: Id74ca13610a4ef407c866a4419139287413078a4 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- src/northbridge/amd/agesa/family16kb/northbridge.c | 26 ---------------------- src/northbridge/amd/pi/00730F01/northbridge.c | 26 ---------------------- 2 files changed, 52 deletions(-)
diff --git a/src/northbridge/amd/agesa/family16kb/northbridge.c b/src/northbridge/amd/agesa/family16kb/northbridge.c index 59749a1..badec55 100644 --- a/src/northbridge/amd/agesa/family16kb/northbridge.c +++ b/src/northbridge/amd/agesa/family16kb/northbridge.c @@ -458,31 +458,6 @@ static void set_resources(device_t dev) } }
-#if 0 /* TODO: Check if needed. */ -static unsigned scan_chains(device_t dev, unsigned max) -{ - unsigned nodeid; - struct bus *link; - device_t io_hub = NULL; - u32 next_unitid = 0x18; - nodeid = amdfam16_nodeid(dev); - if (nodeid == 0) { - for (link = dev->link_list; link; link = link->next) { - //if (link->link_num == sblink) { /* devicetree put IO Hub on link_lsit[sblink] */ - if (link->link_num == 0) { /* devicetree put IO Hub on link_lsit[0] */ - io_hub = link->children; - if (!io_hub || !io_hub->enabled) { - die("I can't find the IO Hub, or IO Hub not enabled, please check the device tree.\n"); - } - /* Now that nothing is overlapping it is safe to scan the children. */ - max = pci_scan_bus(link, 0x00, ((next_unitid - 1) << 3) | 7, 0); - } - } - } - return max; -} -#endif -
unsigned long acpi_fill_hest(acpi_hest_t *hest) { @@ -631,7 +606,6 @@ static struct device_operations northbridge_operations = { .init = DEVICE_NOOP, .acpi_fill_ssdt_generator = northbridge_fill_ssdt_generator, .write_acpi_tables = agesa_write_acpi_tables, - //.scan_bus = scan_chains, /* TODO: */ .enable = 0, .ops_pci = 0, }; diff --git a/src/northbridge/amd/pi/00730F01/northbridge.c b/src/northbridge/amd/pi/00730F01/northbridge.c index 0b6229a..b10da3d 100644 --- a/src/northbridge/amd/pi/00730F01/northbridge.c +++ b/src/northbridge/amd/pi/00730F01/northbridge.c @@ -446,31 +446,6 @@ static void set_resources(device_t dev) static void northbridge_init(struct device *dev) { } -#if 0 /* TODO: Check if needed. */ -static unsigned scan_chains(device_t dev, unsigned max) -{ - unsigned nodeid; - struct bus *link; - device_t io_hub = NULL; - u32 next_unitid = 0x18; - nodeid = amdfam16_nodeid(dev); - if (nodeid == 0) { - for (link = dev->link_list; link; link = link->next) { - //if (link->link_num == sblink) { /* devicetree put IO Hub on link_lsit[sblink] */ - if (link->link_num == 0) { /* devicetree put IO Hub on link_lsit[0] */ - io_hub = link->children; - if (!io_hub || !io_hub->enabled) { - die("I can't find the IO Hub, or IO Hub not enabled, please check the device tree.\n"); - } - /* Now that nothing is overlapping it is safe to scan the children. */ - max = pci_scan_bus(link, 0x00, ((next_unitid - 1) << 3) | 7, 0); - } - } - } - return max; -} -#endif -
unsigned long acpi_fill_hest(acpi_hest_t *hest) { @@ -618,7 +593,6 @@ static struct device_operations northbridge_operations = { .init = northbridge_init, .acpi_fill_ssdt_generator = northbridge_fill_ssdt_generator, .write_acpi_tables = agesa_write_acpi_tables, - //.scan_bus = scan_chains, /* TODO: */ .enable = 0, .ops_pci = 0, };