Reka Norman has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69868 )
Change subject: mb/google/nissa/var/nivviks,yaviks: Remove ISH firmware-name ......................................................................
mb/google/nissa/var/nivviks,yaviks: Remove ISH firmware-name
For nissa, the ISH main firmware will be included in the CSE region in flash instead of loading it from rootfs. So remove the ISH firmware-name.
BUG=b:234776154 TEST=Boot to OS on nirwen and yaviks UFS SKUs. Check ISH firmware is not loaded by kernel, and device still goes to S0i3.
Cq-Depend: chrome-internal:5102230 Change-Id: I68f963e17bc0dbf9db9adaaa3f96f06b8737523b Signed-off-by: Reka Norman rekanorman@chromium.org --- M src/mainboard/google/brya/variants/nivviks/overridetree.cb M src/mainboard/google/brya/variants/yaviks/overridetree.cb 2 files changed, 20 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/69868/1
diff --git a/src/mainboard/google/brya/variants/nivviks/overridetree.cb b/src/mainboard/google/brya/variants/nivviks/overridetree.cb index 9567d4f..76fe43e 100644 --- a/src/mainboard/google/brya/variants/nivviks/overridetree.cb +++ b/src/mainboard/google/brya/variants/nivviks/overridetree.cb @@ -519,10 +519,6 @@ probe STORAGE STORAGE_EMMC end device ref ish on - chip drivers/intel/ish - register "firmware_name" = ""adl_ish_lite.bin"" - device generic 0 on end - end probe STORAGE STORAGE_UFS end device ref ufs on diff --git a/src/mainboard/google/brya/variants/yaviks/overridetree.cb b/src/mainboard/google/brya/variants/yaviks/overridetree.cb index c3b98b5..6b57ada 100644 --- a/src/mainboard/google/brya/variants/yaviks/overridetree.cb +++ b/src/mainboard/google/brya/variants/yaviks/overridetree.cb @@ -212,12 +212,7 @@ end end device ref emmc on end - device ref ish on - chip drivers/intel/ish - register "firmware_name" = ""adl_ish_lite.bin"" - device generic 0 on end - end - end + device ref ish on end device ref ufs on end device ref pch_espi on chip ec/google/chromeec