11 Apr
2020
11 Apr
'20
12:29 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33920 )
Change subject: mb/asus/am1i-a/buildOpts.c: improve the RAM frequency related defines ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33920/6/src/mainboard/asus/am1i-a/b... File src/mainboard/asus/am1i-a/buildOpts.c:
https://review.coreboot.org/c/coreboot/+/33920/6/src/mainboard/asus/am1i-a/b... PS6, Line 107: DDR1866_FREQUENCY
Indeed. […]
What I mean is that the defines below are not needed, because they are defined elsewhere (probably in some other included header). Please remove them in CB:33918
--
To view, visit https://review.coreboot.org/c/coreboot/+/33920
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib2bc605b98ad99066549017697bb483ad3be3910
Gerrit-Change-Number: 33920
Gerrit-PatchSet: 7
Gerrit-Owner: Mike Banon mikebdp2@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Gergely Kiss mail.gery@gmail.com
Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 11 Apr 2020 10:29:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Comment-In-Reply-To: Mike Banon mikebdp2@gmail.com
Gerrit-MessageType: comment