[coreboot-gerrit] [XL] Change in coreboot[main]: soc/intel/snowridge: Add support for Intel Atom Snow Ridge SoC

[Felix Singer (Code Review)]

Attention is currently required from: Angel Pons, Elyes Haouas, Frans Hendriks, Jérémy Compostella, Shuo Liu, Vasiliy Khoruzhick, [e-mail].

Felix Singer has posted comments on this change by [e-mail]. ( https://review.coreboot.org/c/coreboot/+/83321?usp=email )

Change subject: soc/intel/snowridge: Add support for Intel Atom Snow Ridge SoC
......................................................................

Patch Set 49:

(1 comment)

File src/soc/intel/snowridge/acpi/pcie.asl:

https://review.coreboot.org/c/coreboot/+/83321/comment/021f364e_b49de4ef?usp... :
PS28, Line 5: /* Interrupt Map INTA->INTA, INTB->INTB, INTC->INTC, INTD->INTD */
            : 	Name (IQAA, Package() {
            : 		Package() { 0x0000ffff, 0, 0, 16 },
            : 		Package() { 0x0000ffff, 1, 0, 17 },
            : 		Package() { 0x0000ffff, 2, 0, 18 },
            : 		Package() { 0x0000ffff, 3, 0, 19 } })
            : 	Name (IQAP, Package() {
            : 		Package() { 0x0000ffff, 0, _SB.LNKA, 0 },
            : 		Package() { 0x0000ffff, 1, _SB.LNKB, 0 },
            : 		Package() { 0x0000ffff, 2, _SB.LNKC, 0 },
            : 		Package() { 0x0000ffff, 3, _SB.LNKD, 0 } })
            : 
            : 	/* Interrupt Map INTA->INTB, INTB->INTC, INTC->INTD, INTD->INTA */
            : 	Name (IQBA, Package() {
            : 		Package() { 0x0000ffff, 0, 0, 17 },
            : 		Package() { 0x0000ffff, 1, 0, 18 },
            : 		Package() { 0x0000ffff, 2, 0, 19 },
            : 		Package() { 0x0000ffff, 3, 0, 16 } })
            : 	Name (IQBP, Package() {
            : 		Package() { 0x0000ffff, 0, _SB.LNKB, 0 },
            : 		Package() { 0x0000ffff, 1, _SB.LNKC, 0 },
            : 		Package() { 0x0000ffff, 2, _SB.LNKD, 0 },
            : 		Package() { 0x0000ffff, 3, _SB.LNKA, 0 } })
            : 
            : 	/* Interrupt Map INTA->INTC, INTB->INTD, INTC->INTA, INTD->INTB */
            : 	Name (IQCA, Package() {
            : 		Package() { 0x0000ffff, 0, 0, 18 },
            : 		Package() { 0x0000ffff, 1, 0, 19 },
            : 		Package() { 0x0000ffff, 2, 0, 16 },
            : 		Package() { 0x0000ffff, 3, 0, 17 } })
            : 	Name (IQCP, Package() {
            : 		Package() { 0x0000ffff, 0, _SB.LNKC, 0 },
            : 		Package() { 0x0000ffff, 1, _SB.LNKD, 0 },
            : 		Package() { 0x0000ffff, 2, _SB.LNKA, 0 },
            : 		Package() { 0x0000ffff, 3, _SB.LNKB, 0 } })
            : 
            : 	/* Interrupt Map INTA->INTD, INTB->INTA, INTC->INTB, INTD->INTC */
            : 	Name (IQDA, Package() {
            : 		Package() { 0x0000ffff, 0, 0, 19 },
            : 		Package() { 0x0000ffff, 1, 0, 16 },
            : 		Package() { 0x0000ffff, 2, 0, 17 },
            : 		Package() { 0x0000ffff, 3, 0, 18 } })
            : 	Name (IQDP, Package() {
            : 		Package() { 0x0000ffff, 0, _SB.LNKD, 0 },
            : 		Package() { 0x0000ffff, 1, _SB.LNKA, 0 },
            : 		Package() { 0x0000ffff, 2, _SB.LNKB, 0 },
            : 		Package() { 0x0000ffff, 3, _SB.LNKC, 0 } })
            : 
            : 	/* Interrupt Map INTA->INTE, INTB->INTF, INTC->INTG, INTD->INTH */
            : 	Name (IQEA, Package() {
            : 		Package() { 0x0000ffff, 0, 0, 20 },
            : 		Package() { 0x0000ffff, 1, 0, 21 },
            : 		Package() { 0x0000ffff, 2, 0, 22 },
            : 		Package() { 0x0000ffff, 3, 0, 23 } })
            : 	Name (IQEP, Package() {
            : 		Package() { 0x0000ffff, 0, _SB.LNKE, 0 },
            : 		Package() { 0x0000ffff, 1, _SB.LNKF, 0 },
            : 		Package() { 0x0000ffff, 2, _SB.LNKG, 0 },
            : 		Package() { 0x0000ffff, 3, _SB.LNKH, 0 } })
            : 
            : 	/* Interrupt Map INTA->INTF, INTB->INTG, INTC->INTH, INTD->INTE */
            : 	Name (IQFA, Package() {
            : 		Package() { 0x0000ffff, 0, 0, 21 },
            : 		Package() { 0x0000ffff, 1, 0, 22 },
            : 		Package() { 0x0000ffff, 2, 0, 23 },
            : 		Package() { 0x0000ffff, 3, 0, 20 } })
            : 	Name (IQFP, Package() {
            : 		Package() { 0x0000ffff, 0, _SB.LNKF, 0 },
            : 		Package() { 0x0000ffff, 1, _SB.LNKG, 0 },
            : 		Package() { 0x0000ffff, 2, _SB.LNKH, 0 },
            : 		Package() { 0x0000ffff, 3, _SB.LNKE, 0 } })
            : 
            : 	/* Interrupt Map INTA->INTG, INTB->INTH, INTC->INTE, INTD->INTF */
            : 	Name (IQGA, Package() {
            : 		Package() { 0x0000ffff, 0, 0, 22 },
            : 		Package() { 0x0000ffff, 1, 0, 23 },
            : 		Package() { 0x0000ffff, 2, 0, 20 },
            : 		Package() { 0x0000ffff, 3, 0, 21 } })
            : 	Name (IQGP, Package() {
            : 		Package() { 0x0000ffff, 0, _SB.LNKG, 0 },
            : 		Package() { 0x0000ffff, 1, _SB.LNKH, 0 },
            : 		Package() { 0x0000ffff, 2, _SB.LNKE, 0 },
            : 		Package() { 0x0000ffff, 3, _SB.LNKF, 0 } })
            : 
            : 	/* Interrupt Map INTA->INTH, INTB->INTE, INTC->INTF, INTD->INTG */
            : 	Name (IQHA, Package() {
            : 		Package() { 0x0000ffff, 0, 0, 23 },
            : 		Package() { 0x0000ffff, 1, 0, 20 },
            : 		Package() { 0x0000ffff, 2, 0, 21 },
            : 		Package() { 0x0000ffff, 3, 0, 22 } })
            : 	Name (IQHP, Package() {
            : 		Package() { 0x0000ffff, 0, _SB.LNKH, 0 },
            : 		Package() { 0x0000ffff, 1, _SB.LNKE, 0 },
            : 		Package() { 0x0000ffff, 2, _SB.LNKF, 0 },
            : 		Package() { 0x0000ffff, 3, _SB.LNKG, 0 } })
> Done

Very sad.