build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40036 )
Change subject: [WIP]acpi: Get rid of boilerplate FADT
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40036/2/src/acpi/acpi.c
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/40036/2/src/acpi/acpi.c@1277
PS2, Line 1277: switch (DIV_ROUND_UP(reg->bit_width, 8)) {
switch and case should be at the same indent
https://review.coreboot.org/c/coreboot/+/40036/2/src/southbridge/intel/lynxp...
File src/southbridge/intel/lynxpoint/lpc.c:
https://review.coreboot.org/c/coreboot/+/40036/2/src/southbridge/intel/lynxp...
PS2, Line 786: pch_is_lp() ? (2 * 4 * sizeof(uint32_t)) : (2 * 2 * sizeof(uint32_t)),
line over 96 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40036
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If58fcf9a1c39c159dfa08339cb931e552d499747
Gerrit-Change-Number: 40036
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 26 May 2020 09:06:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment