Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35110 )
Change subject: google/kukui: force run dram full-k blob ......................................................................
Patch Set 1:
(2 comments)
I would suggest putting the "complex memory test" loops in a separate function, so as to avoid having it written twice
https://review.coreboot.org/c/coreboot/+/35110/1/src/mainboard/google/kukui/... File src/mainboard/google/kukui/romstage.c:
https://review.coreboot.org/c/coreboot/+/35110/1/src/mainboard/google/kukui/... PS1, Line 106: ASSERT(i == 0); One tab too much?
https://review.coreboot.org/c/coreboot/+/35110/1/src/mainboard/google/kukui/... PS1, Line 118: ASSERT(i == 0); One tab too much?