build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32997 ) Change subject: soc/intel/braswell: Don't use CAR_GLOBAL ...................................................................... Patch Set 3: (4 comments) https://review.coreboot.org/#/c/32997/3/src/soc/intel/braswell/romstage/roms... File src/soc/intel/braswell/romstage/romstage.c: https://review.coreboot.org/#/c/32997/3/src/soc/intel/braswell/romstage/roms... PS3, Line 132: power_state.gen_pmcon1 = read32((void *)(PMC_BASE_ADDRESS + GEN_PMCON1)); line over 80 characters https://review.coreboot.org/#/c/32997/3/src/soc/intel/braswell/romstage/roms... PS3, Line 133: power_state.gen_pmcon2 = read32((void *)(PMC_BASE_ADDRESS + GEN_PMCON2)); line over 80 characters https://review.coreboot.org/#/c/32997/3/src/soc/intel/braswell/romstage/roms... PS3, Line 142: power_state.prsts, power_state.gen_pmcon1, power_state.gen_pmcon2); line over 80 characters https://review.coreboot.org/#/c/32997/3/src/soc/intel/braswell/romstage/roms... PS3, Line 143: printk(BIOS_DEBUG, "prev_sleep_state %d\n", power_state.prev_sleep_state); line over 80 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/32997 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7fa97135a4b376ac0bd8b30093a77614cc2cf55 Gerrit-Change-Number: 32997 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Sat, 25 May 2019 15:37:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment